-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] deps: upgrade libuv to 1.10.0 #8280
Conversation
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/372/ (I think I have it right..) |
I spotted a problem on Windows. A PR will land shortly so I'll update this. |
Updated to fix the Windows build issue. Jenkins seems to be away for the weekend, I'll try to run a CI later. |
CI is green except some RPi binary tests where Jenkins failed to mkdir for some reason. CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/374/ (hopefully I started this one right) |
Fixes #4351 per #4351 (comment) |
Can this land before Node 7? |
I don't know, when does Node 7 land? |
https://github.com/nodejs/node/milestone/15 seems to indicate a code freeze on September 30? Maybe @rvagg or @jasnell can give more details? |
Adding to the 7.0.0 milestone so we don't forget about it. |
The v7.x branch has already been cut. Anything that is semver-patch or semver-minor will be pulled over. Anything semver-major will require CTC review and approval to land in v7.x at this point. The first beta build will be going out today. v7.0.0 is targeted for mid to late October depending largely on when V8 5.4 goes stable, so there's still a short amount of time (but not a lot) |
@jasnell Ack. At the moment we are waiting on a patch to finalize z/OS support, other than that the release is ready. |
Updated the PR with latest v1.x. Can someone help kick off a CITGM? Thanks! |
Thanks Evan! |
I can confirm that this fixes #6763. |
@saghul anything in here that needs to land in v7 specifically, or is this good for many minor / patch version? |
Note, the release hasn't actually happened yet. It is still waiting on libuv/libuv#1037. |
@saghul ... ping... what's the status on this? Should this still be on the v7 milestone? Note that we're a week out from the actual 7.0.0 release. |
If the libuv upgrade doesn't make into 7.0.0, when would the next window for that be? |
that depends on how significant the update will be. If it can be landed as a semver-minor, then it can land any time within v7.x after v7.0.0 is released. If it must be landed as a semver-major, it won't go into a release until next April |
I should be a semver minor, v1x maintains backwards compatibility. The status is we are waiting for some final issues to be ironed out in the On Oct 17, 2016 20:07, "James M Snell" notifications@github.com wrote:
|
c133999
to
83c7a88
Compare
Ok, then I'm going to take this off the v7 milestone critical path. If it lands, great, if not, then it can go into a 7.x minor. |
I'll be sending a replacement PR for this soon. |
Fixes: nodejs#4351 Fixes: nodejs#6763 Refs: nodejs#8280 PR-URL: nodejs#9267 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Fixes: nodejs/node#4351 Fixes: nodejs/node#6763 Refs: nodejs/node#8280 PR-URL: nodejs/node#9267 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
We are planning to release libuv 1.10.0 late next week, this is a placeholder for the update PR, to see if smoke comes out. A few more commits will land before we cut the release.
/cc @cjihrig