Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: moving f function call comment #8405

Closed
wants to merge 1 commit into from
Closed

src: moving f function call comment #8405

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 4, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

@danbev
src: moving f function call comment
7974024 
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 4, 2016
@addaleax
Copy link
Member

addaleax commented Sep 4, 2016

LGTM

@danbev
Copy link
Contributor Author

danbev commented Sep 4, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/3939/

@jasnell
Copy link
Member

jasnell commented Sep 4, 2016

LGTM

@Trott
Copy link
Member

Trott commented Sep 5, 2016

The Raspberry Pi failure is unrelated, of course, and due to some ongoing difficulties that have hopefully been resolved now, but in any event, don't need to hold this up IMO.

@danbev
Copy link
Contributor Author

danbev commented Sep 5, 2016

Landed in a01e8bc

@danbev danbev closed this Sep 5, 2016
danbev added a commit that referenced this pull request Sep 5, 2016
@danbev
src: moving f function call comment
a01e8bc 
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: #8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Fishrock123
Copy link
Contributor

Why was this landed without addressing the comments? I'm 99% certain I posted those here, and not in the landed commit..??

@danbev
Copy link
Contributor Author

danbev commented Sep 6, 2016

I honestly did not notice the comments until after I had committed the
changes and pushed them. I did not intentionally ignore the comments and I
should have waited longer before merging. I was a little too eager but
will make sure to allow more time for reviews. Sorry about this.

tisdag 6 september 2016 skrev Jeremiah Senkpiel notifications@github.com:

Why was this landed without addressing the comments? I'm 99% certain I
posted those here, and not in the landed commit..??

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#8405 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAaY3__HpJJhL4SuYUnTpFCkOL9BJvXAks5qnXNlgaJpZM4J0mlA
.

@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Closed
@danbev danbev deleted the moving-f-function-call-comment branch September 7, 2016 08:14
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
@danbev @Fishrock123
src: moving f function call comment
7d2e27e 
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: nodejs#8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
@danbev @Fishrock123
src: moving f function call comment
4e368c5 
The comment about calling the f function seems to have drifted
a little. Moving it to be closer to the actual call.

PR-URL: #8405
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Mar 9, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @addaleax @jasnell @Trott @Fishrock123 @MylesBorins @nodejs-github-bot