Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline docs: removing unnecessary section on rl.close() method #8497

Closed
wants to merge 1 commit into from
Closed

readline docs: removing unnecessary section on rl.close() method #8497

wants to merge 1 commit into from

Conversation

italoacasas
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Reading the documentation I notice that we have in the readline docs a repeated section in the rl.close() method

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module. labels Sep 12, 2016
@jasnell
Copy link
Member

jasnell commented Sep 12, 2016

LGTM

4 similar comments
@lpinca
Copy link
Member

lpinca commented Sep 12, 2016

LGTM

@princejwesley
Copy link
Contributor

LGTM

@addaleax
Copy link
Member

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Sep 12, 2016

LGTM

@lpinca
Copy link
Member

lpinca commented Sep 15, 2016

Landed in 3c23db4.

lpinca pushed a commit that referenced this pull request Sep 15, 2016
@italoacasas @lpinca
doc: remove duplicate content from readline doc
3c23db4 
Remove a duplicate sentence from the `rl.close()` method description.

PR-URL: #8497
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@lpinca lpinca closed this Sep 15, 2016
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@italoacasas @Fishrock123
doc: remove duplicate content from readline doc
8a1f743 
Remove a duplicate sentence from the `rl.close()` method description.

PR-URL: #8497
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@italoacasas @jasnell @lpinca @princejwesley @addaleax @cjihrig @MylesBorins @nodejs-github-bot