Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add imyller to collaborators #8530

Closed
wants to merge 1 commit into from
Closed

Conversation

imyller
Copy link
Member

@imyller imyller commented Sep 14, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 14, 2016
@Trott
Copy link
Member

Trott commented Sep 14, 2016

LGTM

@imyller
Copy link
Member Author

imyller commented Sep 14, 2016

@lpinca
Copy link
Member

lpinca commented Sep 14, 2016

LGTM

@thefourtheye
Copy link
Contributor

@imyller Please make sure that you follow the guidelines given in the COLLABORATOR_GUIDE while landing the commits.

@thefourtheye
Copy link
Contributor

LGTM and welcome :-)

imyller added a commit that referenced this pull request Sep 14, 2016
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@imyller
Copy link
Member Author

imyller commented Sep 14, 2016

Landed in 2804518

@imyller imyller closed this Sep 14, 2016
@jbergstroem
Copy link
Member

🎉!

@Trott
Copy link
Member

Trott commented Sep 16, 2016

@imyller is involved in embedded technologies. He maintains this: https://github.com/imyller/meta-nodejs So, he's all about cross-compiling and so on.

Not sure who it might be useful to connect him with about this stuff, but was wondering specifically about @nodejs/build and/or @nodejs/hardware...

MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

PR-URL: #8530
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants