Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix link on timers.md #8562

Closed
wants to merge 1 commit into from
Closed

doc: fix link on timers.md #8562

wants to merge 1 commit into from

Conversation

Ltrlg
Copy link
Contributor

@Ltrlg Ltrlg commented Sep 16, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix a link in timers doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Sep 16, 2016
yorkie
yorkie approved these changes Sep 16, 2016
View reviewed changes
Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lpinca
lpinca approved these changes Sep 16, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

princejwesley
princejwesley approved these changes Sep 16, 2016
View reviewed changes
Copy link
Contributor

@princejwesley princejwesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca
Copy link
Member

lpinca commented Sep 19, 2016

@Ltrlg your git config uses "Ltrlg" as author name. Are you ok with this?
This is what will be shown in https://github.com/nodejs/node/blob/master/AUTHORS.

@Ltrlg
Copy link
Contributor Author

Ltrlg commented Sep 19, 2016

@lpinca I’m fine with this.

@lpinca
Copy link
Member

lpinca commented Sep 19, 2016

@Ltrlg ok.
Landed in 4e76bff.

@lpinca lpinca closed this Sep 19, 2016
lpinca pushed a commit that referenced this pull request Sep 19, 2016
@Ltrlg @lpinca
doc: fix broken link in timers doc
4e76bff 
PR-URL: #8562
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Ltrlg @Fishrock123
doc: fix broken link in timers doc
2f6101e 
PR-URL: #8562
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@princejwesley princejwesley princejwesley approved these changes

@yorkie yorkie yorkie approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Ltrlg @lpinca @princejwesley @yorkie @MylesBorins @nodejs-github-bot