Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: make v8-bench.js output consistent #8564

Closed
wants to merge 1 commit into from

Conversation

bzoz
Copy link
Contributor

@bzoz bzoz commented Sep 16, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

Description of change

This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

cc @nodejs/benchmarking

This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.
@bzoz bzoz added the benchmark Issues and PRs related to the benchmark subsystem. label Sep 16, 2016
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Sep 16, 2016
@AndreasMadsen
Copy link
Member

LGTM

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member

jasnell commented Sep 22, 2016

@nodejs/benchmarking ... comments?

@gareth-ellis
Copy link
Member

Consistency is always a good thing. LGTM

bzoz added a commit that referenced this pull request Sep 26, 2016
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
PR-URL: #8564
@bzoz
Copy link
Contributor Author

bzoz commented Sep 26, 2016

Landed in 9e5a06e

@bzoz bzoz closed this Sep 26, 2016
jasnell pushed a commit that referenced this pull request Sep 29, 2016
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
PR-URL: #8564
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
This changes the way v8-bench.js reports its performance to be consistent
with other benchmarks.

Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
PR-URL: nodejs#8564
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants