-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: Remove deprecated/unused function requireRepl. Part of #4642 #8575
Conversation
c44e76d
to
6be1333
Compare
What's the usage look like in the ecosystem? /cc @ChALkeR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if ecosystem breakage is limited.
Most of those are LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the commit log needs to conform to the style guide.
@bnoordhuis can you point me in the right direction? Not sure what is wrong with the commit log. |
See CONTRIBUTING.md in the top-level directory; for example, the first line should be <= 50 characters, links to GH issues should be Refs: or Fixes: tags, etc. |
Ah I see, thanks, will update soon |
6be1333
to
8a89112
Compare
8a89112
to
cd9db93
Compare
@bnoordhuis I think it is conform now |
Landed in 4d6297f. Thank you! |
@nodejs/ctc ... any objections to landing this in v7.x? |
No 😉 |
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
module
Description of change
Remove deprecated/unused function requireRepl.