-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor test-crypto test files #8597
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. when landing the commits will need to be squashed and the commit messages should be fixed up.
@griffithtp ... thank you for this. Just to point out, the contributing.md file in the node.js project root directly includes the guidelines for commit message formatting. The person who lands this can clean these commits up but if you'd like to give it a go yourself that would be great! |
@jasnell apologies for this. Rookie mistake. |
Yep. Specifically, the steps are |
57d10f6
to
435437f
Compare
Cool, thanks James @jasnell ! |
Well, there’s https://github.com/nodejs/node/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+contribution%22 if you’re feeling up for one of those?
I don’t want to steal your thunder or anything, but… keep in mind that the kind of tasks we were doing was chosen specifically to have some good contributions to get used to the process. You can definitely look through the test files and watch for anything that you would consider a significant improvement! Also, things that we just always need are more benchmarks + more tests (code coverage on Linux). |
... and doc fixes! we always need doc fixes! |
|
@griffithtp can you take a look at the lint issues? |
c133999
to
83c7a88
Compare
435437f
to
92c7917
Compare
Apologies for late reply. |
ping @griffithtp Sorry that this PR didn't get more attention. Do you want to rebase (again, sorry!) and ping me? Then I'll start the CI and we can land this. Thanks, sorry for the extra work. |
* invoke callback with `common.mustCall()` in test-crypto-hash * order module declarations aphabetically per test-writing-guide
92c7917
to
e650c6f
Compare
I took the liberty of rebasing, resolving conflicts, and pushing to your branch. Hope that's OK! Given the staleness of the PR, I figured it probably wasn't a problem. I also edited the commit message a bit to reflect commit message guidelines and the narrower scope of the PR now that it's been rebased (because some of the changes in this PR were already done elsewhere). |
Landed in 1df9340. Thanks for the contribution! 🎉 |
* invoke callback with `common.mustCall()` in test-crypto-hash * order module declarations aphabetically per test-writing-guide PR-URL: #8597 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* invoke callback with `common.mustCall()` in test-crypto-hash * order module declarations aphabetically per test-writing-guide PR-URL: #8597 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* invoke callback with `common.mustCall()` in test-crypto-hash * order module declarations aphabetically per test-writing-guide PR-URL: #8597 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Checklist
make lint
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesDescription of change
Updated ./test/parallel/test-crypto*
var
toconst
assert.equal
toassert.StrictEqual
, same withnotEqual
common.mustCall()