Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update var to const #8599

Closed
wants to merge 1 commit into from
Closed

test: update var to const #8599

wants to merge 1 commit into from

Conversation

matt-in-a-hat
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
Affected core subsystem(s)

test

Description of change

Updated var to const

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 17, 2016
cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex mscdex added the cluster Issues and PRs related to the cluster subsystem. label Sep 17, 2016
@imyller
Copy link
Member

imyller commented Sep 17, 2016

@matt-in-a-hat Could you include reference to specific test in commit message? Thank you.

@matt-in-a-hat matt-in-a-hat force-pushed the test-cluster-disconnect-unshared-udp branch from 81cb07b to d3a3ba1 Compare September 20, 2016 07:40
lpinca
lpinca approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyller
Copy link
Member

imyller commented Sep 20, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4158/

@imyller imyller self-assigned this Sep 20, 2016
imyller
imyller approved these changes Sep 20, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imyller
Copy link
Member

imyller commented Sep 20, 2016

I'll start landing this.

  • Three LGTMs
  • No objections
  • CI test passed (usual unrelated failures)

imyller pushed a commit to imyller/node that referenced this pull request Sep 20, 2016
@matt-in-a-hat @imyller
test: update test-cluster-disconnect-unshared-udp
57b7e85 
Changed var to const

PR-URL: nodejs#8599
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@imyller
Copy link
Member

imyller commented Sep 20, 2016

landed in 57b7e85

Thank you for your contribution, @matt-in-a-hat

@imyller imyller closed this Sep 20, 2016
@imyller imyller removed their assignment Sep 20, 2016
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@matt-in-a-hat @Fishrock123
test: update test-cluster-disconnect-unshared-udp
bcba27e 
Changed var to const

PR-URL: #8599
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@imyller imyller imyller approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matt-in-a-hat @imyller @lpinca @cjihrig @mscdex @MylesBorins @nodejs-github-bot