test: Improved tests in test-os #8606

delvedor · 2016-09-17T09:52:33Z

Checklist

make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

test

Affected test

test-os

Description of change

Moved all variables declaration from var to const
Moved from .equal to .strictEqual
Added more checks about the type of the returned values.

Part of code & learn.
Cc: @mcollina

mcollina · 2016-09-17T11:03:00Z

Can you please shorten the commit message and include the name of the test you are changing?

mcollina · 2016-09-17T11:03:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4080/

delvedor · 2016-09-17T11:14:48Z

Done!

mcollina · 2016-09-17T12:47:15Z

https://ci.nodejs.org/job/node-test-commit-arm/5000/nodes=ubuntu1604-arm64/ failed. Seems highly unrelated.

cc @addaleax @jasnell

addaleax · 2016-09-17T14:40:05Z

That failure looks more like a build problem that might be fixed by just cleaning up on the build machine? /cc @nodejs/build

cjihrig · 2016-09-17T12:36:14Z

test/parallel/test-os.js

  delete process.env.HOME;
  assert.ok(os.homedir().indexOf(path.sep) !== -1);
  process.env.HOME = home;
 }

 const pwd = os.userInfo();
+console.log('pwd = ', pwd);


Could you remove this.

cjihrig · 2016-09-17T12:36:59Z

test/parallel/test-os.js

+const path = require('path');
+
+const is = {
+  string: (value) => { assert.ok(typeof value === 'string'); },


These could be, for example, assert.strictEqual(typeof value, 'string');.

cjihrig · 2016-09-17T12:37:16Z

test/parallel/test-os.js

+  string: (value) => { assert.ok(typeof value === 'string'); },
+  number: (value) => { assert.ok(typeof value === 'number'); },
+  array: (value) => { assert.ok(Array.isArray(value)); },
+  object: (value) => { assert.ok(typeof value === 'object'); }


This should also check for null.

Sure, originally I wrote the not null test here, but since typeof null === 'object' I thought the is.object with this check was a nonsense.
Anyhow, now I added it again, let me know if something else is missing :)

Fishrock123

See @cjihrig's comments

jbergstroem · 2016-09-17T18:27:08Z

Cleaning up the host now.

cjihrig

LGTM

mcollina

LGTM, can you please squash the commits?

Moved from var to const. Moved from .equal to .strictEqual. Added more checks about the type of the returned values.

imyller · 2016-09-20T11:56:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/4155/

imyller · 2016-09-20T11:58:10Z

@Fishrock123 Could you revise your review. I think the issues mentioned have been addressed.

jasnell

LGTM

targos

LGTM

imyller · 2016-09-21T00:35:46Z

Any objections to start landing this?

I see that there are four LGTMs for Reviewed-By and the requested code changes have been made.

jasnell · 2016-09-21T00:39:28Z

Go for it!

imyller · 2016-09-21T00:49:49Z

I'll start landing this:

Five LGTMs
No objections
Requested code changes have been completed
CI tests passed (only usual CI failures)

Moved from var to const. Moved from .equal to .strictEqual. Added more checks about the type of the returned values. PR-URL: nodejs#8606 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

imyller · 2016-09-21T00:55:51Z

landed in 66df5d1

Thank you for your contribution, @delvedor

Moved from var to const. Moved from .equal to .strictEqual. Added more checks about the type of the returned values. PR-URL: #8606 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>

nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 17, 2016

delvedor changed the title ~~test: Moved from var to const, equal to strictEqual and added typeof tests~~ test: Improved tests in test-os Sep 17, 2016

mscdex added the os Issues and PRs related to the os subsystem. label Sep 17, 2016

cjihrig reviewed Sep 17, 2016

View reviewed changes

Fishrock123 suggested changes Sep 17, 2016

View reviewed changes

cjihrig approved these changes Sep 17, 2016

View reviewed changes

mcollina approved these changes Sep 18, 2016

View reviewed changes

test: Improved tests in test-os

5e5dbf2

Moved from var to const. Moved from .equal to .strictEqual. Added more checks about the type of the returned values.

imyller self-assigned this Sep 20, 2016

jasnell approved these changes Sep 20, 2016

View reviewed changes

targos approved these changes Sep 20, 2016

View reviewed changes

Trott force-pushed the master branch from b0df363 to c5ce7f4 Compare September 21, 2016 00:10

imyller closed this Sep 21, 2016

imyller removed their assignment Sep 21, 2016

delvedor deleted the test-os branch September 21, 2016 08:23

MylesBorins added the dont-land-on-v4.x label Oct 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Improved tests in test-os #8606

test: Improved tests in test-os #8606

delvedor commented Sep 17, 2016 •

edited

Loading

mcollina commented Sep 17, 2016

mcollina commented Sep 17, 2016

delvedor commented Sep 17, 2016

mcollina commented Sep 17, 2016

addaleax commented Sep 17, 2016

cjihrig Sep 17, 2016

cjihrig Sep 17, 2016

cjihrig Sep 17, 2016

delvedor Sep 17, 2016

Fishrock123 left a comment

jbergstroem commented Sep 17, 2016

cjihrig left a comment

mcollina left a comment

imyller commented Sep 20, 2016

imyller commented Sep 20, 2016

jasnell left a comment

targos left a comment

imyller commented Sep 21, 2016

jasnell commented Sep 21, 2016

imyller commented Sep 21, 2016 •

edited

Loading

imyller commented Sep 21, 2016

test: Improved tests in test-os #8606

test: Improved tests in test-os #8606

Conversation

delvedor commented Sep 17, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Affected test

Description of change

mcollina commented Sep 17, 2016

mcollina commented Sep 17, 2016

delvedor commented Sep 17, 2016

mcollina commented Sep 17, 2016

addaleax commented Sep 17, 2016

cjihrig Sep 17, 2016

Choose a reason for hiding this comment

cjihrig Sep 17, 2016

Choose a reason for hiding this comment

cjihrig Sep 17, 2016

Choose a reason for hiding this comment

delvedor Sep 17, 2016

Choose a reason for hiding this comment

Fishrock123 left a comment

Choose a reason for hiding this comment

jbergstroem commented Sep 17, 2016

cjihrig left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

imyller commented Sep 20, 2016

imyller commented Sep 20, 2016

jasnell left a comment

Choose a reason for hiding this comment

targos left a comment

Choose a reason for hiding this comment

imyller commented Sep 21, 2016

jasnell commented Sep 21, 2016

imyller commented Sep 21, 2016 • edited Loading

imyller commented Sep 21, 2016

delvedor commented Sep 17, 2016 •

edited

Loading

imyller commented Sep 21, 2016 •

edited

Loading