Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: properly handle fd passed to truncate() #866

Closed
wants to merge 2 commits into from
Closed

fs: properly handle fd passed to truncate() #866

wants to merge 2 commits into from

Commits on Feb 18, 2015

  1. fs: properly handle fd passed to truncate() 

    Currently, fs.truncate() silently fails when a file descriptor
is passed as the first argument. This commit changes this
behavior to properly call fs.ftruncate().

PR-URL: nodejs/node-v0.x-archive#9161
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Timothy J Fontaine <tjfontaine@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Conflicts:
	lib/fs.js
    @bjouhier @cjihrig
    bjouhier authored and cjihrig committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    7077e77 View commit details
    Browse the repository at this point in the history

  2. fs: add type checking to makeCallback() 

    This commit adds proper type checking to makeCallback(). Anything
other than undefined or a function will throw.

PR-URL: #866
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @cjihrig
    cjihrig committed Feb 18, 2015
    Configuration menu
    Copy the full SHA
    3d1e49e View commit details
    Browse the repository at this point in the history