Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: improve setTimeout/Interval performance #8661

Merged
merged 1 commit into from
Oct 1, 2016
Merged

timers: improve setTimeout/Interval performance #8661

merged 1 commit into from
Oct 1, 2016

Commits on Oct 1, 2016

  1. timers: improve setTimeout/Interval performance 

    This commit improves timers performance by making functions
inlineable and avoiding the creation of extra closures/functions.

This commit also makes setTimeout/Interval argument handling
consistent with that of setImmediate.

These changes give ~22% improvement in the existing 'breadth' timers
benchmark.

PR-URL: nodejs#8661
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @mscdex
    mscdex committed Oct 1, 2016
    Configuration menu
    Copy the full SHA
    c8c2544 View commit details
    Browse the repository at this point in the history