benchmark: add info about required Unix tools #8788
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds note to README.md about Unix tools being required by some benchmarks
nodejs-github-bot
added
the
benchmark
gibfahn
reviewed
Sep 26, 2016
| @@ -34,6 +34,10 @@ benchmarker to be used by providing it as an argument, e. g.: | |||
|
|
|||
| `node benchmark/http/simple.js benchmarker=autocannon` | |||
|
|
|||
| Basic Unix tools are required for some benchmarks. | |||
| [Git for Windows][git-for-windows] includes Git Bash and tools which can be | |||
| included in the global `PATH`. | |||
There was a problem hiding this comment.
Maybe Git for Windows includes Git bash and the necessary tools, which need to be included in the global Windows path
|
Updated, PTAL |
lpinca
approved these changes
Sep 27, 2016
|
LGTM |
gibfahn
approved these changes
Sep 27, 2016
|
LGTM |
jasnell
approved these changes
Sep 27, 2016
|
LGTM |
1 similar comment
|
LGTM |
mhdawson
approved these changes
Sep 29, 2016
jasnell
pushed a commit
that referenced
this pull request
Sep 30, 2016
This adds note to README.md about Unix tools being required by some benchmarks PR-URL: #8788 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 3e7da1d. thank you! |
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
This adds note to README.md about Unix tools being required by some benchmarks PR-URL: #8788 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Conflicts and isn't really necessary on v6, feel free to make a PR if you really want it. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
benchmark
Description of change
This adds note to
README.mdabout Unix tools being required by some benchmarks as requested in #8721 discussion./cc @nodejs/benchmarking