build: make addons build dep. on node_version.h #8861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the `test/addons/.buildstamp` file dependent on `src/node_version.h` since addons need to be re-compiled after `NODE_MODULE_VERSION` bumps, e.g. as it happened recently in b5bdff8.
addaleax
added
build
nodejs-github-bot
added
the
build
cjihrig
approved these changes
Sep 30, 2016
bnoordhuis
approved these changes
Oct 3, 2016
|
Landing:
|
imyller
pushed a commit
to imyller/node
that referenced
this pull request
Oct 5, 2016
Make the `test/addons/.buildstamp` file dependent on `src/node_version.h` since addons need to be re-compiled after `NODE_MODULE_VERSION` bumps, e.g. as it happened recently in b5bdff8. PR-URL: nodejs#8861 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell
pushed a commit
that referenced
this pull request
Oct 6, 2016
Make the `test/addons/.buildstamp` file dependent on `src/node_version.h` since addons need to be re-compiled after `NODE_MODULE_VERSION` bumps, e.g. as it happened recently in b5bdff8. PR-URL: #8861 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Fishrock123
pushed a commit
that referenced
this pull request
Oct 11, 2016
Make the `test/addons/.buildstamp` file dependent on `src/node_version.h` since addons need to be re-compiled after `NODE_MODULE_VERSION` bumps, e.g. as it happened recently in b5bdff8. PR-URL: #8861 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
|
This is not landing cleanly, @addaleax is this blocked by other PR's being landed first? |
|
@thealphanerd I am not sure why I labelled this lts-watch in the first place, I don’t think there’s really any point in backporting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
addon tests
Description of change
Make the
test/addons/.buildstampfile dependent onsrc/node_version.hsince addons need to be re-compiled afterNODE_MODULE_VERSIONbumps, e.g. as it happened recently in b5bdff8.