test: cleanup/update test-dgram-error-message-address.js

[Goyapa]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

test
dgram

Description of change

test: cleanup/update test-dgram-error-message-address.js

* Changed some var to const
* This commit resolves #8925

[cjihrig]

LGTM, but there is some other cleanup that you could do while you're here. Like getting rid of assert.equal() and assert.notEqual().

[Trott]

• Can you rebase/squash so that there aren't unrelated commits in the PR?

These changes would make this change more compelling:

• assert.equal() -> assert.strictEqual()
• assert.notEqual() -> assert.notStrictEqual()
• The use of common.fail can be improved. Perhaps create a function that wraps it so that it prints a sensible message.

[imyller]

Fixes: #8925

[lpinca]

@Goyapa while you are at it can you please replace assert.equal() with assert.strictEqual() and assert.notEqual() with assert.notStrictEqual().

Also you can use the Fixes: metadata instead of This commit resolves #8925 as defined in CONTRIBUTING.md.

[Goyapa]

@ipinca
My Laptop died, an i do not know when i am able to continue.
Sorry, how to process now?

[lpinca]

@Goyapa we can use https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/ if it is not a problem for you.

[addaleax]

You can also try to edit files on your branch using Github’s web interface, it’s a bit tricky but it’s nice when you don’t want to or can’t use a local git client.

[Goyapa]

@lpinca
Allow edits from maintainers is checked v.

[Goyapa]

@lpinca
See that nothing has changed at this file on master.
I`m on it again!

[targos]

CI: https://ci.nodejs.org/job/node-test-pull-request/5006/

[targos]

Landed in 6a73d61