build: make node-gyp output silent #8990

thefourtheye · 2016-10-09T14:30:15Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

build

Description of change

As it is, node-gyp produces a lot of build related verbose messages.
Latest node-gyp upgrade allows us to specify --silent flag to suppress
those messages.

cc @nodejs/build

gibfahn · 2016-10-09T16:49:34Z

I agree that the output is a bit excessive when the addons build successfully, but when they fail it is important to get the whole output.

@thefourtheye When an addon fails to build do we still get the full verbose output with the --silent flag?

thefourtheye · 2016-10-09T17:32:53Z

@gibfahn No, we will get only the failures. Would it be better if we can disabling silent output explicitly?

gibfahn · 2016-10-09T21:37:47Z

I think in general we want as little output as possible when something succeeds, and plenty of info when it fails.

Ideally we'd have silent output for a passing build and verbose output for a failure (like the default output of the test runner). This may not currently be an option in node-gyp, but IMO that'd be the best thing to work towards.

If that's not possible we definitely need an option to run with verbose output, not least for CI (if something fails on the CI you don't really want to have to run it again to get more info).

thefourtheye · 2016-10-31T10:23:15Z

Now, we can pass the loglevel explicitly and by default it will be silent.

thefourtheye · 2016-10-31T10:23:52Z

cc @nodejs/collaborators

danbev · 2016-10-31T10:42:32Z

Makefile

@@ -165,7 +166,8 @@ test/addons/.buildstamp: config.gypi \
 	# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
 	# embedded addons have been generated from the documentation.
 	for dirname in test/addons/*/; do \


Nit: could we make this @for instead to not have the command echoed in the console log?

@danbev As it is there is no indication in the command line that which command is actually being executed. I feel that it is better to have. If we feel strongly about this, this can be changed.

@thefourtheye No strong feelings from my side. Was more if the goal was to reduce the amount of output.

danbev · 2016-10-31T10:42:57Z

LGTM

rvagg · 2016-10-31T11:54:25Z

lgtm

gibfahn

Could you change the LOGLEVEL in the test-ci targets so that it matches what we had before?

As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently.

thefourtheye · 2016-10-31T12:26:26Z

@gibfahn PTAL. I made them to use info as the loglevel, which was what we had before.

gibfahn · 2016-10-31T12:46:11Z

LGTM, CI: https://ci.nodejs.org/job/node-test-pull-request/4753/

imyller

LGTM

indutny

LGTM if it works.

gibfahn · 2016-11-02T14:56:44Z

Landed in 54d3431

As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: #8990 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

MylesBorins · 2016-11-22T07:36:55Z

I've landed this on v6.x-staging but not on v4.x

@thefourtheye can you confirm this is unnecessary for v4.x

As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: #8990 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

thefourtheye · 2016-11-22T07:43:31Z

@thealphanerd Ya, this patch will not have any effect in v4.

daviddias · 2016-11-30T11:10:19Z

subscribing to this one, looking forward to see it released :)

As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: nodejs#8990 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: #8990 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>

thefourtheye added the build Issues and PRs related to build files or the CI. label Oct 9, 2016

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 9, 2016

rvagg force-pushed the master branch 2 times, most recently from c133999 to 83c7a88 Compare October 18, 2016 17:02

thefourtheye force-pushed the make-gyp-output-silent branch from 9206ae1 to 9a082e6 Compare October 31, 2016 10:22

danbev reviewed Oct 31, 2016

View reviewed changes

danbev approved these changes Oct 31, 2016

View reviewed changes

gibfahn suggested changes Oct 31, 2016

View reviewed changes

build: make node-gyp output silent

8a8b805

As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently.

thefourtheye force-pushed the make-gyp-output-silent branch from 9a082e6 to 8a8b805 Compare October 31, 2016 12:23

gibfahn approved these changes Oct 31, 2016

View reviewed changes

imyller approved these changes Oct 31, 2016

View reviewed changes

indutny approved these changes Oct 31, 2016

View reviewed changes

jasnell approved these changes Nov 2, 2016

View reviewed changes

gibfahn closed this Nov 2, 2016

thefourtheye deleted the make-gyp-output-silent branch November 2, 2016 14:56

evanlucas mentioned this pull request Nov 3, 2016

v7.1.0 proposal - 2016-11-08 #9438

Merged

MylesBorins added the dont-land-on-v4.x label Nov 22, 2016

MylesBorins added the land-on-v6.x label Nov 22, 2016

MylesBorins mentioned this pull request Nov 22, 2016

v6.9.2 proposal #9735

Merged

thefourtheye mentioned this pull request Dec 21, 2016

v4.x backport silent logs in addons tests #10366

Closed

2 tasks

MylesBorins mentioned this pull request Dec 21, 2016

V4.7.1 proposal #10395

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: make node-gyp output silent #8990

build: make node-gyp output silent #8990

thefourtheye commented Oct 9, 2016

gibfahn commented Oct 9, 2016

thefourtheye commented Oct 9, 2016

gibfahn commented Oct 9, 2016

thefourtheye commented Oct 31, 2016

thefourtheye commented Oct 31, 2016

danbev Oct 31, 2016

thefourtheye Oct 31, 2016

danbev Oct 31, 2016

danbev commented Oct 31, 2016

rvagg commented Oct 31, 2016

gibfahn left a comment

thefourtheye commented Oct 31, 2016

gibfahn commented Oct 31, 2016

imyller left a comment

indutny left a comment

gibfahn commented Nov 2, 2016

MylesBorins commented Nov 22, 2016

thefourtheye commented Nov 22, 2016

daviddias commented Nov 30, 2016

build: make node-gyp output silent #8990

build: make node-gyp output silent #8990

Conversation

thefourtheye commented Oct 9, 2016

Checklist

Affected core subsystem(s)

Description of change

gibfahn commented Oct 9, 2016

thefourtheye commented Oct 9, 2016

gibfahn commented Oct 9, 2016

thefourtheye commented Oct 31, 2016

thefourtheye commented Oct 31, 2016

danbev Oct 31, 2016

Choose a reason for hiding this comment

thefourtheye Oct 31, 2016

Choose a reason for hiding this comment

danbev Oct 31, 2016

Choose a reason for hiding this comment

danbev commented Oct 31, 2016

rvagg commented Oct 31, 2016

gibfahn left a comment

Choose a reason for hiding this comment

thefourtheye commented Oct 31, 2016

gibfahn commented Oct 31, 2016

imyller left a comment

Choose a reason for hiding this comment

indutny left a comment

Choose a reason for hiding this comment

gibfahn commented Nov 2, 2016

MylesBorins commented Nov 22, 2016

thefourtheye commented Nov 22, 2016

daviddias commented Nov 30, 2016