fix:events.js has a clerical error #9004
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
events
|
'iff' is shorthand for 'if and only if'. |
|
get it. thanks. |
|
This does, however, beg the question - wouldn't it be clearer to just use EDIT: nevermind, |
|
It doesn't really matter here but if, say, you are documenting the preconditions of a complex algorithm, then 'iff' is less distracting than 'if and only if' spelled out ten times. This seems to be the only place where 'iff' is used in the source. I'm fine with changing it but it's churn for very marginal benefits. |
|
If we decide to move forward with this change, we should take the time to capitalize and punctuate the comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
events.js has a clerical error