Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,benchmark: fix lint errors on v6.x #9029

Closed
wants to merge 0 commits into from
Closed

test,benchmark: fix lint errors on v6.x #9029

wants to merge 0 commits into from

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented Oct 11, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test,benchmark

Description of change

cc @Trott / @thealphanerd could you sign off?

CI: https://ci.nodejs.org/job/node-test-pull-request/4457/

Edit: I chose this route because finding the commits is indirect and painful and requires large rebases and stuff

@Fishrock123 Fishrock123 added the test Issues and PRs related to the tests. label Oct 11, 2016
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests. v6.x labels Oct 11, 2016
@Fishrock123 Fishrock123 added this to the v6.8.0 milestone Oct 11, 2016
addaleax
addaleax approved these changes Oct 11, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

LGTM

@MylesBorins
Copy link
Contributor

Those BSD are kind of concerning, but likely not to do with this

@Fishrock123 Fishrock123 mentioned this pull request Oct 11, 2016
Closed
Fishrock123 added a commit that referenced this pull request Oct 11, 2016
@Fishrock123
test,benchmark: fix lint errors on v6.x
5a7dd18 
PR-URL: #9029
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@Fishrock123 Fishrock123 force-pushed the fix-v6.x-staging-lint branch from c7dd0f0 to 5a7dd18 Compare October 11, 2016 19:47
@Fishrock123
Copy link
Contributor Author

Landed in 5a7dd18 thanks

@Trott
Copy link
Member

Trott commented Oct 11, 2016

Guess I'm late to this one but LGTM after the fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
6.8.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Fishrock123 @MylesBorins @Trott @addaleax @nodejs-github-bot