Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix building when using --without-intl #9041

Closed
wants to merge 1 commit into from
Closed

url: fix building when using --without-intl #9041

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 11, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

url

Description of change

Fix compile bug when building with the --without-intl option
(introduced by 4b31238)

@jasnell
url: fix building when using --without-intl
cfe6f43 
Fix compile bug when building with the --without-intl option
(introduced by 4b31238)
@jasnell jasnell added the url Issues and PRs related to the legacy built-in url module. label Oct 11, 2016
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 11, 2016
@MylesBorins
Copy link
Contributor

tested locally to confirm

LGTM

@jasnell
Copy link
Member Author

jasnell commented Oct 12, 2016

Given that building --without-intl is broken without this, I'd like to land this sooner than later.

@jasnell
Copy link
Member Author

jasnell commented Oct 12, 2016

Landing now to unbreak building when using the --without-intl flag

jasnell added a commit that referenced this pull request Oct 12, 2016
@jasnell
url: fix building when using --without-intl
774d737 
Fix compile bug when building with the --without-intl option
(introduced by 4b31238)

PR-URL: #9041
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Oct 12, 2016

Landed in 774d737

@jasnell jasnell closed this Oct 12, 2016
@bnoordhuis bnoordhuis mentioned this pull request Oct 12, 2016
Closed
@evanlucas evanlucas mentioned this pull request Oct 12, 2016
Closed
@Fishrock123
Copy link
Contributor

doesn't apply cleanly, assuming this does not need a backport (node_url does not exist)

@jasnell
Copy link
Member Author

jasnell commented Oct 12, 2016

This requires 4b31238 in order to land.

@MylesBorins
Copy link
Contributor

that si correct

On Wed, Oct 12, 2016, 10:45 AM Jeremiah Senkpiel notifications@github.com
wrote:

doesn't apply cleanly, assuming this does not need a backport (node_url
does not exist)

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#9041 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV-pLje6b4QRCkqg8tK6D2pOXNV17ks5qzOi-gaJpZM4KULVy
.

jasnell added a commit that referenced this pull request Oct 12, 2016
@jasnell
url: fix building when using --without-intl
1afd7c1 
Fix compile bug when building with the --without-intl option
(introduced by 4b31238)

PR-URL: #9041
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @MylesBorins @Fishrock123 @cjihrig @nodejs-github-bot