Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: explain why we don't use the GitHub merge button #9044

Closed
wants to merge 2 commits into from
Closed

doc: explain why we don't use the GitHub merge button #9044

wants to merge 2 commits into from

Commits on Oct 12, 2016

  1. doc: explain why GitHub merge button is not used 

    Adds documentation and explicit reasons on why
the GitHub web interface button is not used. This was
explained in the referenced issue by @thealphanerd.

Fixes: nodejs#8893
    @jalafel
    jalafel committed Oct 12, 2016
    Configuration menu
    Copy the full SHA
    d42d56f View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2016

  1. doc: explains why Reviewed-By is added in PRs 

    Adds verbose reasons to the documentation on why the
Reviewed-By metadata on a pull request is important.
This was loosely mentioned as an issue in the referenced
issue below, and answered by @addaleax.

Ref: nodejs#8893

change wording on documentation update

Changes the initial commit to the recommended, and more
accurate wording.

Removed time qualifiers on documentation for git merge

removes the ugly wording

add a new reason why autosquashing is prohibited
    @jalafel
    jalafel committed Oct 13, 2016
    Configuration menu
    Copy the full SHA
    177d880 View commit details
    Browse the repository at this point in the history