Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: name anonymous functions #9047

Closed
wants to merge 1 commit into from
Closed

console: name anonymous functions #9047

wants to merge 1 commit into from

Conversation

tylerbrazier
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

console

Description of change

Ref: #8913

@nodejs-github-bot nodejs-github-bot added the console Issues and PRs related to the console subsystem. label Oct 12, 2016
@tylerbrazier tylerbrazier changed the title console: naming anonymouse functions console: naming anonymous functions Oct 12, 2016
imyller
imyller approved these changes Oct 12, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

targos
targos approved these changes Oct 12, 2016
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jasnell
jasnell approved these changes Oct 12, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

lpinca
lpinca approved these changes Oct 12, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca
Copy link
Member

lpinca commented Oct 12, 2016

Nit: replace "naming" with "name" in commit message title.

@tylerbrazier tylerbrazier changed the title console: naming anonymous functions console: name anonymous functions Oct 12, 2016
@lpinca
Copy link
Member

lpinca commented Oct 16, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4532/

lpinca pushed a commit that referenced this pull request Oct 16, 2016
@tylerbrazier @lpinca
console: name anonymous functions
2ebd445 
Ref: #8913
PR-URL: #9047
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Oct 16, 2016

  • Approvals (LGTM): 4
  • No objections
  • The PR has been open for the minimum time of 48 or 72 hours
  • All of the requested changes have been made
  • CI has only unrelated failures

Landed in 2ebd445.
Thank you!

@lpinca lpinca closed this Oct 16, 2016
@tylerbrazier tylerbrazier deleted the console-fn-names branch October 17, 2016 00:10
jasnell pushed a commit that referenced this pull request Oct 17, 2016
@tylerbrazier @jasnell
console: name anonymous functions
bd7d7a7 
Ref: #8913
PR-URL: #9047
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 9, 2017
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
@MylesBorins MylesBorins added dont-land-on-v6.x and removed baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@imyller imyller imyller approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tylerbrazier @lpinca @jasnell @imyller @targos @MylesBorins @nodejs-github-bot