-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: name anonymous functions #9051
Conversation
6cbc2a9
to
abacec2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
_throws(true, block, error, message); | ||
}; | ||
|
||
// EXTENSION! This is annoying to write outside this module. | ||
assert.doesNotThrow = function(block, /*optional*/error, /*optional*/message) { | ||
assert.doesNotThrow = function doesNotThrow(block, /*optional*/error, /*optional*/message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maasencioh I think the linter is not happy with this line as it is too long.
Can you please fix this? Thank you.
8af025a
to
c769bac
Compare
@lpinca done! |
c133999
to
83c7a88
Compare
landed in ef030da. Thank you! |
Thanks! |
Checklist
Description of change
Ref: #8913