doc: edit Stream api grammar #9100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sections: - Introduction - Orginization of this Document - Object Mode - Buffering - API for Stream Implementers
nodejs-github-bot
added
doc
cjihrig
approved these changes
Oct 14, 2016
addaleax
approved these changes
Oct 14, 2016
| @@ -1061,7 +1061,7 @@ Examples of Transform streams include: | |||
| <!--type=misc--> | |||
|
|
|||
| The `stream` module API has been designed to make it possible to easily | |||
| implement streams using JavaScript's prototypical inheritance model. | |||
| implement streams using JavaScript's prototypal inheritance model. | |||
There was a problem hiding this comment.
http://www.merriam-webster.com/dictionary/prototypal ;)
(not complaining, I just giggled a bit at this. 😄)
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2016
Sections: - Introduction - Orginization of this Document - Object Mode - Buffering - API for Stream Implementers PR-URL: #9100 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in 3c4349e. Thank you! |
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2016
Sections: - Introduction - Orginization of this Document - Object Mode - Buffering - API for Stream Implementers PR-URL: #9100 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 11, 2016
Sections: - Introduction - Orginization of this Document - Object Mode - Buffering - API for Stream Implementers PR-URL: #9100 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Sections: