Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix changelog index for v6.9.0 #9168

Closed
wants to merge 1 commit into from
Closed

doc: fix changelog index for v6.9.0 #9168

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 18, 2016

No description provided.

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v6.x labels Oct 18, 2016
@rvagg rvagg force-pushed the v6.x-changelog-fix branch from a2c0aec to 1a163e3 Compare October 18, 2016 17:21
addaleax
addaleax approved these changes Oct 18, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I’m okay with fast-tracking this

lpinca
lpinca approved these changes Oct 18, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mscdex
Copy link
Contributor

mscdex commented Oct 18, 2016

LGTM

evanlucas
evanlucas approved these changes Oct 18, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rvagg
Copy link
Member Author

rvagg commented Oct 19, 2016

fwiw it was fast tracked on to master already, I squashed it all together in the single release commit for the changelog there so it's only the v6.x branch that's impacted now cause I noticed it after I'd built and tag. Thanks for the reviews folks!

rvagg added a commit that referenced this pull request Oct 19, 2016
@rvagg
doc: fix changelog index for v6.9.0
f81d8c4 
PR-URL: #9168
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@rvagg
Copy link
Member Author

rvagg commented Oct 19, 2016

f81d8c4 on v6.x-staging

@rvagg rvagg closed this Oct 19, 2016
@rvagg rvagg deleted the v6.x-changelog-fix branch October 19, 2016 02:21
MylesBorins pushed a commit that referenced this pull request Oct 19, 2016
@rvagg
doc: fix changelog index for v6.9.0
2c3bbb5 
PR-URL: #9168
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins MylesBorins mentioned this pull request Oct 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rvagg @mscdex @jasnell @evanlucas @addaleax @lpinca @targos @nodejs-github-bot