Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 3.10.9 #9286

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 3.10.9 #9286

wants to merge 1 commit into from

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Oct 26, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • deps
Description of change

Lo and behold, I come bearing a shiny new npm@3 release! Since we've released npm@4, over at #9284, this is quite possibly one of the final npm@3 releases, barring critical and security bugfixes. As far as things go on our own end, we consider both npm@2 and npm@3 to be in maintenance mode, but will continue to support both versions, as far as working-with-the-registry-and-for-most-uses, until y'all's current LTS versions lapse. We'll be putting our efforts into npm@4 from here on out, and then npm@5 which will follow suit early next year.

Notable Changes
  • Many bugfixes, including a fairly significant shrinkwrap issue with git and tagged dependencies
  • Doc updates
  • Dep updates
Changelogs

r: @jasnell
r: @Fishrock123

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Oct 26, 2016
@mscdex
Copy link
Contributor

mscdex commented Oct 26, 2016 •
edited
Loading

Shouldn't this target the v6.x branch (and v4.x) instead of master, since npm v4 is the one that has breaking changes?

@JLHwung JLHwung mentioned this pull request Oct 26, 2016
Closed
@zkat
Copy link
Contributor Author

zkat commented Oct 26, 2016

@mscdex iiuc, node@7 is still grabbing patches from master, right? It's not certain that it'll upgrade to npm@4 right away, so I figured I'd make this PR against master. lmk if I should actually switch it to v6.x though. (node@4 is forever on npm@2, though, so it won't use this patch).

@Fishrock123
Copy link
Contributor

Fishrock123 commented Oct 26, 2016 •
edited
Loading

FWIW as I alluded to in #9284 (comment), node v6 (now in LTS) is stuck with shipping npm@3 for the next year and a half or so.

@jasnell
Copy link
Member

jasnell commented Oct 26, 2016

well, since we haven't yet landed npm4 into master and it's not clear exactly when that will happen, then having this also is fine. If we happen to land npm4 first then we can close this. We should have separate PRs for v6 and v4 also tho.

@richardlau
Copy link
Member

v4 still bundles npm@2 (hence the dont-land-on-v4.x label).

@jasnell
Copy link
Member

jasnell commented Oct 26, 2016

oh.. that's right. forgot that we hadn't updated that one.

@Fishrock123
Copy link
Contributor

Tests pass, landed in 3790978

@Fishrock123 Fishrock123 closed this Nov 4, 2016
Fishrock123 pushed a commit that referenced this pull request Nov 4, 2016
@zkat @Fishrock123
deps: upgrade npm to 3.10.9
3790978 
PR-URL: #9286
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
evanlucas pushed a commit that referenced this pull request Nov 7, 2016
@zkat @evanlucas
deps: upgrade npm to 3.10.9
f1f00df 
PR-URL: #9286
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@evanlucas evanlucas mentioned this pull request Nov 7, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
@zkat
deps: upgrade npm to 3.10.9
2230c26 
PR-URL: #9286
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
@MylesBorins
2016-12-06, Version 6.9.2 'Boron' (LTS) Release
4e11cae 
This LTS release comes with 144 commits. This includes 47 that are docs
related, 46 that are test related, 15 which are build / tools related,
and 9 commits which are updates to dependencies

Notable Changes:

* buffer:
  - coerce slice parameters consistently
    (Sakthipriyan Vairamani (thefourtheye))
    #9101
* deps:
    - *npm*:
      - upgrade npm to 3.10.9 (Kat Marchán)
       #9286
    - *V8*:
      - Various fixes to destructuring edge cases
        - cherry-pick 3c39bac from V8 upstream (Cristian Cavalli)
          #9138
        - cherry pick 7166503 from upstream v8 (Cristian Cavalli)
          #9173
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* inspector:
  - inspector now prompts user to use 127.0.0.1 rather than localhost
    (Eugene Ostroukhov) #9451
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9735
MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
@MylesBorins
2016-12-06, Version 6.9.2 'Boron' (LTS) Release
94a3aef 
This LTS release comes with 144 commits. This includes 47 that are docs
related, 46 that are test related, 15 which are build / tools related,
and 9 commits which are updates to dependencies

Notable Changes:

* buffer:
  - coerce slice parameters consistently
    (Sakthipriyan Vairamani (thefourtheye))
    #9101
* deps:
    - *npm*:
      - upgrade npm to 3.10.9 (Kat Marchán)
       #9286
    - *V8*:
      - Various fixes to destructuring edge cases
        - cherry-pick 3c39bac from V8 upstream (Cristian Cavalli)
          #9138
        - cherry pick 7166503 from upstream v8 (Cristian Cavalli)
          #9173
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* inspector:
  - inspector now prompts user to use 127.0.0.1 rather than localhost
    (Eugene Ostroukhov) #9451
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9735
MylesBorins pushed a commit that referenced this pull request Dec 6, 2016
@MylesBorins
2016-12-06, Version 6.9.2 'Boron' (LTS) Release
c4391f4 
This LTS release comes with 144 commits. This includes 47 that are docs
related, 46 that are test related, 15 which are build / tools related,
and 9 commits which are updates to dependencies

Notable Changes:

* buffer:
  - coerce slice parameters consistently
    (Sakthipriyan Vairamani (thefourtheye))
    #9101
* deps:
    - *npm*:
      - upgrade npm to 3.10.9 (Kat Marchán)
       #9286
    - *V8*:
      - Various fixes to destructuring edge cases
        - cherry-pick 3c39bac from V8 upstream (Cristian Cavalli)
          #9138
        - cherry pick 7166503 from upstream v8 (Cristian Cavalli)
          #9173
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) #9262
* inspector:
  - inspector now prompts user to use 127.0.0.1 rather than localhost
    (Eugene Ostroukhov) #9451
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    #9586

PR-URL: #9735
imyller added a commit to imyller/meta-nodejs that referenced this pull request Dec 7, 2016
@imyller
2016-12-06, Version 6.9.2 'Boron' (LTS) Release
33c85e7 
    This LTS release comes with 144 commits. This includes 47 that are docs
    related, 46 that are test related, 15 which are build / tools related,
    and 9 commits which are updates to dependencies

    Notable Changes:

    * buffer:
      - coerce slice parameters consistently
        (Sakthipriyan Vairamani (thefourtheye))
        nodejs/node#9101
    * deps:
        - *npm*:
          - upgrade npm to 3.10.9 (Kat Marchan)
           nodejs/node#9286
        - *V8*:
          - Various fixes to destructuring edge cases
            - cherry-pick 3c39bac from V8 upstream (Cristian Cavalli)
              nodejs/node#9138
            - cherry pick 7166503 from upstream v8 (Cristian Cavalli)
              nodejs/node#9173
    * gtest:
      - the test reporter now outputs tap comments as yamlish
        (Johan Bergstrom) nodejs/node#9262
    * inspector:
      - inspector now prompts user to use 127.0.0.1 rather than localhost
        (Eugene Ostroukhov) nodejs/node#9451
    * tls:
      - fix memory leak when writing data to TLSWrap instance during
        handshake (Fedor Indutny)
        nodejs/node#9586

    PR-URL: nodejs/node#9735

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Dec 7, 2016
@imyller
2016-12-06, Version 6.9.2 'Boron' (LTS) Release
0ff3916 
    This LTS release comes with 144 commits. This includes 47 that are docs
    related, 46 that are test related, 15 which are build / tools related,
    and 9 commits which are updates to dependencies

    Notable Changes:

    * buffer:
      - coerce slice parameters consistently
        (Sakthipriyan Vairamani (thefourtheye))
        nodejs/node#9101
    * deps:
        - *npm*:
          - upgrade npm to 3.10.9 (Kat Marchan)
           nodejs/node#9286
        - *V8*:
          - Various fixes to destructuring edge cases
            - cherry-pick 3c39bac from V8 upstream (Cristian Cavalli)
              nodejs/node#9138
            - cherry pick 7166503 from upstream v8 (Cristian Cavalli)
              nodejs/node#9173
    * gtest:
      - the test reporter now outputs tap comments as yamlish
        (Johan Bergstrom) nodejs/node#9262
    * inspector:
      - inspector now prompts user to use 127.0.0.1 rather than localhost
        (Eugene Ostroukhov) nodejs/node#9451
    * tls:
      - fix memory leak when writing data to TLSWrap instance during
        handshake (Fedor Indutny)
        nodejs/node#9586

    PR-URL: nodejs/node#9735

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishrock123 Fishrock123 Fishrock123 approved these changes

Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@zkat @mscdex @Fishrock123 @jasnell @richardlau @nodejs-github-bot