test: run all of test-timers-blocking-callback #9305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test has two test cases, but only the first was being run due to a small bug. This change fixes the bug.
Trott
added
timers
misterdjules
approved these changes
Oct 27, 2016
There was a problem hiding this comment.
Good catch, and my apologies again. This test is definitely not written in a way that makes it easy to reason about it.
These changes look good to me. Eventually it would be good to also assert on the number of blockingCallback calls, but that can be done in a separate PR. This is already a significant improvement.
cjihrig
approved these changes
Oct 27, 2016
jasnell
reviewed
Oct 28, 2016
| @@ -56,24 +56,24 @@ function blockingCallback(callback) { | |||
| common.busyLoop(TIMEOUT); | |||
|
|
|||
| timeCallbackScheduled = Timer.now(); | |||
| setTimeout(blockingCallback, TIMEOUT); | |||
| setTimeout(blockingCallback.bind(null, callback), TIMEOUT); | |||
There was a problem hiding this comment.
setTimeout(() => blockingCallback(callback), TIMEOUT); ?
There was a problem hiding this comment.
I did it this way to match what was already on line 67 so that it was clear that they were doing the same thing.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2016
The test has two test cases, but only the first was being run due to a small bug. This change fixes the bug. PR-URL: nodejs#9305 Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 2c6ca32 |
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
The test has two test cases, but only the first was being run due to a small bug. This change fixes the bug. PR-URL: #9305 Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
The test has two test cases, but only the first was being run due to a small bug. This change fixes the bug. PR-URL: #9305 Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test timers
Description of change
The test has two test cases, but only the first was being run due to a
small bug. This change fixes the bug.
/cc @misterdjules
Refs: #8041