process: maintain constructor descriptor #9306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the original property descriptor instead of just taking the value, which would, by default, be non-writable and non-configurable.
nodejs-github-bot
added
the
lib / src
|
LGTM with green CI |
cjihrig
approved these changes
Oct 27, 2016
|
What's this aiming to solve? 🤔 |
|
@Fishrock123 an inconsistency in what's publicly provided in node. We're doing some automated iterating over node's public API objects, and inconsistencies can trip up our code. We can write in some exceptions, but it would be nice to not have to, especially in this case, as the non-configurability is not actually required here (it seems), and was just put there due to the way the property descriptor was originally used there. |
targos
approved these changes
Nov 27, 2016
|
@Fishrock123 ... you good with this? |
|
ping @Fishrock123 |
|
Ping... status on this one? |
addaleax
approved these changes
Mar 24, 2017
|
Fresh CI: https://ci.nodejs.org/job/node-test-commit/8674/ Will land if it comes back green. |
|
Landed in e0bc5a7 |
addaleax
pushed a commit
that referenced
this pull request
Mar 24, 2017
Use the original property descriptor instead of just taking the value, which would, by default, be non-writable and non-configurable. PR-URL: #9306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
Use the original property descriptor instead of just taking the value, which would, by default, be non-writable and non-configurable. PR-URL: #9306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
|
should this be backported? it lands cleanly. |
|
@MylesBorins I'd say yes. |
MylesBorins
pushed a commit
that referenced
this pull request
May 15, 2017
Use the original property descriptor instead of just taking the value, which would, by default, be non-writable and non-configurable. PR-URL: #9306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Use the original property descriptor instead of just taking the value, which would, by default, be non-writable and non-configurable. PR-URL: nodejs/node#9306 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
process
Description of change
Use the original property descriptor instead of just taking the value,
which would previously, by default, be non-writable and non-configurable.
It didn't appear that it was intentional for
process.constructor's descriptorto be locked down, but it was, by using a simple
{value: ...}descriptor.