Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add child_process customFds test #9307

Merged
merged 2 commits into from
Oct 29, 2016
Merged

test: add child_process customFds test #9307

merged 2 commits into from
Oct 29, 2016

Commits on Oct 29, 2016

  1. test: add child_process customFds test 

    This commit adds a test for spawn()'s deprecated customFds option.

PR-URL: nodejs#9307
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    d0ed173 View commit details
    Browse the repository at this point in the history

  2. child_process: remove unreachable code 

    _convertCustomFds() is only called from normalizeSpawnArguments(),
which always provides an options object. Therefore, there is no
need to check for options in _convertCustomFds().

PR-URL: nodejs#9307
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @cjihrig
    cjihrig committed Oct 29, 2016
    Configuration menu
    Copy the full SHA
    ec7c27f View commit details
    Browse the repository at this point in the history