test: clean up dgram-broadcast-multi-process test #9308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use assert.strictEqual() instead of assert.equal(), === instead of ==, and const instead of var.
|
LGTM Not running full CI because Linter job on CI: https://ci.nodejs.org/job/node-test-linter/5014/ |
Trott
approved these changes
Oct 27, 2016
cjihrig
approved these changes
Oct 27, 2016
jasnell
approved these changes
Oct 28, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Oct 29, 2016
Use assert.strictEqual() instead of assert.equal(), === instead of ==, and const instead of var. PR-URL: nodejs#9308 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in b9f6a2d. Thanks! |
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
Use assert.strictEqual() instead of assert.equal(), === instead of ==, and const instead of var. PR-URL: #9308 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
Use assert.strictEqual() instead of assert.equal(), === instead of ==, and const instead of var. PR-URL: #9308 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Bryan English <bryan@bryanenglish.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
Use assert.strictEqual() instead of assert.equal(), === instead of ==, and const instead of var.