Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated reference to signal list in "signal events" section #9323

Closed
wants to merge 3 commits into from
Closed

Updated reference to signal list in "signal events" section #9323

wants to merge 3 commits into from

Conversation

emadb
Copy link
Contributor

@emadb emadb commented Oct 27, 2016

Documentation is changed or added.
Changed the reference from sigaction(2) to signal(7) like requested in issue #9309

@emadb
Updated reference to signal list in "signal events" section
05a2e66 
Changed the reference from sigaction(2) to signal(7) like requested in issue nodejs#9309
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Oct 27, 2016
cjihrig
cjihrig requested changes Oct 27, 2016
View reviewed changes
doc/api/process.md
@@ -374,7 +374,7 @@ The `*-deprecation` command line flags only affect warnings that use the name
<!--name=SIGINT, SIGHUP, etc.-->

Signal events will be emitted when the Node.js process receives a signal. Please
refer to sigaction(2) for a listing of standard POSIX signal names such as
refer to [signal(7)](http://man7.org/linux/man-pages/man7/signal.7.html) for a listing of standard POSIX signal names such as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the URL to the bottom of the page with the others.

@mscdex
Copy link
Contributor

mscdex commented Oct 27, 2016 •
edited
Loading

I don't think a link needs to be explicitly added since the doc tools automatically insert links when they see man page references. So just changing the 'sigaction(2)' to 'signal(7)' should be enough.

@emadb
Copy link
Contributor Author

emadb commented Oct 27, 2016

@mscdex didn't about it. I wait for a feedback from @cjihrig if I have to remove the link.
Thx (this is my very first try to help).

@cjihrig
Copy link
Contributor

cjihrig commented Oct 27, 2016

Sorry @emadb, I didn't remember that the doc tools could recognize man pages. @mscdex is right.

@emadb
Removed the link
c5b29a2 
I removed the link since the doc tool automatically add link to man pages.
@mscdex
Copy link
Contributor

mscdex commented Oct 27, 2016

LGTM

@sam-github
Copy link
Contributor

@cjihrig I think you have to mark your requested changes as having been made (I'm not loving the new review system yet).

LGTM

sam-github pushed a commit that referenced this pull request Oct 27, 2016
@emadb @sam-github
doc: reference signal(7) for the list of signals
6893f3c 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@sam-github
Copy link
Contributor

Landed in 6893f3c, thanks @emadb

@sam-github sam-github closed this Oct 27, 2016
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@emadb @evanlucas
doc: reference signal(7) for the list of signals
c745890 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
@emadb
doc: reference signal(7) for the list of signals
ec90f73 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins pushed a commit that referenced this pull request Nov 11, 2016
@emadb
doc: reference signal(7) for the list of signals
f472c09 
Fixes: #9309
PR-URL: #9323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
This was referenced Nov 22, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@emadb @mscdex @cjihrig @sam-github @MylesBorins @nodejs-github-bot