-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: updating OpenSSL links #9338
Conversation
4240ff2
to
ba060d8
Compare
LGTM The links will need to be updated when OpenSSL is updated in deps/. I can't see any docs for how the OpenSSL update is made, I guess @nodejs/crypto folks will have to remember. |
I added this info to https://github.com/nodejs/node/wiki/OpenSSL-upgrade-process#performing-the-upgrade. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, landed in facd843. |
PR-URL: #9338 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #9338 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #9338 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Checklist
Affected core subsystem(s)
doc
Description of change
Update OpenSSL links in docs to reference version 1.0.2.
The following pull-request moved the OpenSSL docs breaking a lot of links in the node docs: openssl/openssl#1758
There are now separate pages for different versions and master. For example https://www.openssl.org/docs/apps/ca.html is no longer accessible, but it's available at
https://www.openssl.org/docs/man1.0.2/apps/ca.html and https://www.openssl.org/docs/manmaster/man1/ca.html
Resolves #9327