Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: updating OpenSSL links #9338

Closed
wants to merge 1 commit into from
Closed

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Oct 28, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Update OpenSSL links in docs to reference version 1.0.2.

The following pull-request moved the OpenSSL docs breaking a lot of links in the node docs: openssl/openssl#1758

There are now separate pages for different versions and master. For example https://www.openssl.org/docs/apps/ca.html is no longer accessible, but it's available at
https://www.openssl.org/docs/man1.0.2/apps/ca.html and https://www.openssl.org/docs/manmaster/man1/ca.html

Resolves #9327

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 28, 2016
@kobelb kobelb changed the title Updating doc links to openssl doc: updating OpenSSL links Oct 28, 2016
@mscdex mscdex added the openssl Issues and PRs related to the OpenSSL dependency. label Oct 28, 2016
@sam-github
Copy link
Contributor

LGTM

The links will need to be updated when OpenSSL is updated in deps/. I can't see any docs for how the OpenSSL update is made, I guess @nodejs/crypto folks will have to remember.

@silverwind
Copy link
Contributor

Copy link
Contributor

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silverwind
Copy link
Contributor

Thanks, landed in facd843.

@silverwind silverwind closed this Nov 1, 2016
silverwind pushed a commit that referenced this pull request Nov 1, 2016
PR-URL: #9338
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
PR-URL: #9338
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Nov 22, 2016
PR-URL: #9338
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
@targos targos mentioned this pull request Jan 8, 2017
@targos targos mentioned this pull request Sep 4, 2017
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants