doc: fs: fix link to mkdtemp #9379
Conversation
nodejs-github-bot
added
doc
|
Your author name in this commit is given as “coderaiser”. Is that intended or do you prefer to be listed (changelog, git log, AUTHORS file) with some other name? People typically prefer their full name, but ultimately it’s up to you. |
|
@addaleax I'm good to be listed with name |
| [Common System Errors]: errors.html#errors_common_system_errors |
There was a problem hiding this comment.
What is changed here? Newline added at the end?
There was a problem hiding this comment.
@thefourtheye Yes, that. (Didn’t github use to show this?)
There was a problem hiding this comment.
@addaleax I think it would show a red carriage return or something.
There was a problem hiding this comment.
It doesn't show anything on my browser :'(
There was a problem hiding this comment.
Yea mine either. I noticed this same thing earlier. A newline seems to make the most sense.
There was a problem hiding this comment.
Sorry, no visible changes to display 😄
There was a problem hiding this comment.
Yes, it's a LF. GitHub only shows when it's missing.
|
LGTM, landed in ffa4227. |
PR-URL: #9379 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #9379 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #9379 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Checklist
Affected core subsystem(s)
Documentation of
fsmodule in nodev7.0.0.Description of change
Fixed link to
fs.mkdtemp()fromfs.mkdtempSync: add options.