-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: increase test-net-GH-5504 timeout #9444
Conversation
@nodejs/testing |
Example failure: https://ci.nodejs.org/job/node-test-commit-smartos/5059/nodes=smartos14-64/console
|
I was already running a stress test on CI: https://ci.nodejs.org/job/node-stress-single-test/nodes=smartos14-64/1050/. There's already failures, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with stress test run green
Typo in commit description |
Fixed, thanks! |
Increasing the timeout results in a less reliable test, judging from the stress test results. That's puzzling. |
test-net-nodejsGH-5504 failed on smartos14-64 in CI. The internal test timeout expired. It is currently 2 seconds. That appears to be somewhat arbitrary. It may be possible to rewrite the test without the timer. As an immediate workaround, increase the timeout to 5 seconds.
Closing in favor of #9461 |
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test net
Description of change
test-net-GH-5504 failed on smartos14-64 in CI. The internal test timeout
expired. It is currently 2 seconds. That appears to be somewhat
arbitrary. It may be possible to rewrite the test without the timer. As
an immediate workaround, increase the timeout to 5 seconds.