-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix helper-debugger-repl.js #9486
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI.
@nodejs/testing |
cjihrig
approved these changes
Nov 6, 2016
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I forget - why are the debugger tests not run on the CI? Is it because they aren't in good enough shape?
Yes. |
santigimeno
approved these changes
Nov 6, 2016
jasnell
approved these changes
Nov 7, 2016
JungMinu
approved these changes
Nov 7, 2016
princejwesley
approved these changes
Nov 7, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 10, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: nodejs#9486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Landed in 1323db0 |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: nodejs#9486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
The test `debugger/test-debugger-repl-break-in-module` (and probably others) was failing because the handshake message for debugging is no longer `listening on port <port>` but is instead `listening on <address>:<port>`. This change makes the check less strict so as to hopefully future-proof it at least a little bit against subsequent changes. This test failure is not caught in CI because currently debugger tests are not run in CI. PR-URL: #9486 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
test debugger
Description of change
The test
debugger/test-debugger-repl-break-in-module
(and probablyothers) was failing because the handshake message for debugging is no
longer
listening on port <port>
but is insteadlistening on <address>:<port>
.This change makes the check less strict so as to hopefully future-proof
it at least a little bit against subsequent changes.
This test failure is not caught in CI because currently debugger tests
are not run in CI.