build: remove valgrind from Makefile #9517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like V8 doesn't ship valgrind anymore. So all the valgrind based targets will fail.
thefourtheye
added
build
nodejs-github-bot
added
build
|
cc @nodejs/build @bnoordhuis |
|
I think it should be salvageable so I've put together #9520. If we decide to go ahead with this pull request, you should delete tools/run-valgrind.py. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
build tools
Description of change
Looks like V8 doesn't ship valgrind anymore. So all the valgrind based
targets will fail.