test: increase coverage of process.emitWarning #9556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
process
cjihrig
approved these changes
Nov 11, 2016
addaleax
approved these changes
Nov 12, 2016
| @@ -24,6 +26,10 @@ function CustomWarning() { | |||
| util.inherits(CustomWarning, Error); | |||
| process.emitWarning(new CustomWarning()); | |||
|
|
|||
| const warningNoToString = new CustomWarning(); | |||
| warningNoToString.toString = null; | |||
There was a problem hiding this comment.
I wonder if we should also handle cases where toString() is a function but throws?
Fishrock123
force-pushed
the
process-warnings-coverage
branch
from
a10be3b
to
179cd0f
Compare
Fishrock123
force-pushed
the
process-warnings-coverage
branch
from
179cd0f
to
9e698bd
Compare
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
Previously our tests did not check these codepaths as seen at coverage.nodejs.org PR-URL: #9556 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Previously our tests did not check these codepaths as seen at coverage.nodejs.org PR-URL: nodejs#9556 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Previously our tests did not check these codepaths as seen at coverage.nodejs.org PR-URL: #9556 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test, process
Description of change
Previously our tests did not check these codepaths as seen at
coverage.nodejs.org
See https://coverage.nodejs.org/coverage-fb05e31466ac0bad/root/internal/process/warning.js.html
Ci: https://ci.nodejs.org/job/node-test-pull-request/4825/
(This patch was made live during https://www.twitch.tv/nodesource/v/100431274 if you'd like to see me working on this in retrospect. :P)