doc: changes to process warning documentation #9590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
doc
nodejs-github-bot
added
doc
|
Also, the duplicate documentation about the various |
silverwind
approved these changes
Nov 13, 2016
princejwesley
approved these changes
Nov 13, 2016
cjihrig
approved these changes
Nov 13, 2016
mscdex
force-pushed
the
doc-process-example
branch
from
575eda4 to
88093e8
Compare
PR-URL: nodejs#9590 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
process.emitWarning() already describes how to emit custom warnings, so just merely provide a link to that function from the 'warning' event documentation. PR-URL: nodejs#9590 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
mscdex
force-pushed
the
doc-process-example
branch
from
88093e8 to
5242114
Compare
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9590 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
process.emitWarning() already describes how to emit custom warnings, so just merely provide a link to that function from the 'warning' event documentation. PR-URL: #9590 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
@mscdex should this be backported to v6? |
|
@thealphanerd I would say so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
This PR simplifies the 'Avoiding duplicate warnings' example for
process.emitWarning()and removes redundant documentation.