Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 5.5 #9618

Closed
wants to merge 6 commits into from
Closed

deps: update V8 to 5.5 #9618

wants to merge 6 commits into from

Commits on Jan 21, 2017

  1. deps: update V8 to 5.5.372.40 

    PR-URL: nodejs#9618
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @targos
    targos committed Jan 21, 2017
    Configuration menu
    Copy the full SHA
    785d3f5 View commit details
    Browse the repository at this point in the history

  2. src: update NODE_MODULE_VERSION to 52 

    V8 5.5 is not API/ABI compatible with 5.4.
This commit increments NODE_MODULE_VERSION by one.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: nodejs#9618
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @targos
    targos committed Jan 21, 2017
    Configuration menu
    Copy the full SHA
    d219b89 View commit details
    Browse the repository at this point in the history

  3. deps: limit regress/regress-crbug-514081 v8 test 

    regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @mhdawson @targos
    mhdawson authored and targos committed Jan 21, 2017
    Configuration menu
    Copy the full SHA
    6c714fb View commit details
    Browse the repository at this point in the history

  4. test: move test-vm-function-redefinition to parallel 

    With the upstream fix in V8, function declarations now
work fine in the vm module and the test is no longer failing.

Refs: https://codereview.chromium.org/2334733002
Fixes: nodejs#548
PR-URL: nodejs#9618
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @fhinkel @targos
    fhinkel authored and targos committed Jan 21, 2017
    Configuration menu
    Copy the full SHA
    18344e1 View commit details
    Browse the repository at this point in the history

  5. repl: remove workaround for function redefinition 

    The issue is fixed upstream in V8. Thus we do not need this workaround
in REPL.

Fixes: nodejs#548
PR-URL: nodejs#9618
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @targos
    targos committed Jan 21, 2017
    Configuration menu
    Copy the full SHA
    dfb29bf View commit details
    Browse the repository at this point in the history

  6. string_decoder: align UTF-8 handling with V8 

    V8 5.5 changed how invalid characters are handled and it now appears
to follow the WHATWG Encoding standard, where all of an invalid
character's bytes are replaced by a single replacement character
(\ufffd) instead of replacing each invalid byte with separate
replacement characters.

Example: the byte sequence 0xF0,0xB8,0x41 is decoded as '\ufffdA' in
V8 5.5, but is decoded as '\ufffd\ufffdA' in previous versions of V8.

PR-URL: nodejs#9618
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mscdex @targos
    mscdex authored and targos committed Jan 21, 2017
    Configuration menu
    Copy the full SHA
    6cb91e2 View commit details
    Browse the repository at this point in the history