Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12 npm@2 update to latest (v2.15.11) #9619

Merged
merged 1 commit into from
Nov 18, 2016

Conversation

Fishrock123
Copy link
Contributor

Checklist
  • make -j8 test-npm passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps, npm

Description of change

See nodejs/Release#143. This is an update to the latest npm@2 (v2.15.11) for 0.12.x.

R=@thealphanerd, @rvagg, also @nodejs/npm if you could verify I did this correctly.

@Fishrock123 Fishrock123 added npm Issues and PRs related to the npm client dependency or the npm registry. v0.12 labels Nov 15, 2016
@nodejs-github-bot nodejs-github-bot added npm Issues and PRs related to the npm client dependency or the npm registry. v0.12 labels Nov 15, 2016
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM tests pass locally

@rvagg
Copy link
Member

rvagg commented Nov 18, 2016

did some manual testing locally and I can't find a fault with this, so lgtm

@Fishrock123
Copy link
Contributor Author

@rvagg want me to land it or would you prefer to do it along with the release?

@rvagg
Copy link
Member

rvagg commented Nov 18, 2016

@Fishrock123 would you mind landing it on v0.12-staging please?

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@Fishrock123 Fishrock123 merged commit 653b462 into nodejs:v0.12-staging Nov 18, 2016
Fishrock123 added a commit to Fishrock123/node that referenced this pull request Nov 18, 2016
Refs: nodejs/Release#143
PR-URL: nodejs#9619
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@Fishrock123
Copy link
Contributor Author

Landed in 653b462

jBarz pushed a commit to ibmruntimes/node that referenced this pull request Dec 22, 2016
Refs: nodejs/Release#143
PR-URL: nodejs/node#9619
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants