Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-inspector #9727

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-inspector #9727

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 21, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test V8_inspector

Description of change

Using socket.destroy() instead of socket.end() fixes
more-than-intermittent ECONNRESET issues on Windows.

Fixes: #8804

/cc @eugeneo @gibfahn

Stress test on master showing 93 failures in 100 runs on Windows 10: https://ci.nodejs.org/job/node-stress-single-test/1063/nodes=win10/console

Stress test with this change showing 0 failures in 100 runs on Windows 10:
https://ci.nodejs.org/job/node-stress-single-test/1066/nodes=win10/console

@Trott Trott added test Issues and PRs related to the tests. inspector Issues and PRs related to the V8 inspector protocol windows Issues and PRs related to the Windows platform. labels Nov 21, 2016
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 21, 2016
@Trott Trott mentioned this pull request Nov 21, 2016
Closed
@Trott
Copy link
Member Author

Trott commented Nov 21, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4928/

gibfahn
gibfahn approved these changes Nov 21, 2016
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Interesting that it's the opposite to what @santigimeno suggested in #5386 (comment).

Is there a reason you only ran the test 100 times? Don't we normally run 9999 times to check for flakyness?

@Trott
Copy link
Member Author

Trott commented Nov 21, 2016 •
edited
Loading

Is there a reason you only ran the test 100 times? Don't we normally run 9999 times to check for flakyness?

Normally, yes, but ~93% failure rate makes it seem like 100 is enough. But hey, let's go big: https://ci.nodejs.org/job/node-stress-single-test/1068/nodes=win10/console

UPDATE: 9999 runs and it's all ✅ green.

@Trott
Copy link
Member Author

Trott commented Nov 21, 2016

CI is ✅ green!

eugeneo
eugeneo approved these changes Nov 21, 2016
View reviewed changes
Copy link
Contributor

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Trott
test: fix flaky test-inspector
dd78cc7 
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

Fixes: nodejs#8804
@Trott Trott force-pushed the fix-test-inspector branch from e1366de to dd78cc7 Compare November 22, 2016 14:07
@Trott
Copy link
Member Author

Trott commented Nov 22, 2016

Made a small change (removed the flaky designation for the test in inspector.status). Re-running CI out of an abundance of caution: https://ci.nodejs.org/job/node-test-pull-request/4940/

Trott added a commit to Trott/io.js that referenced this pull request Nov 23, 2016
@Trott
test: fix flaky test-inspector
2486273 
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

PR-URL: nodejs#9727
Fixes: nodejs#8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
@Trott
Copy link
Member Author

Trott commented Nov 23, 2016

Landed in 2486273. Welcome back, green CI. Please stay a while, will ya?

@Trott Trott closed this Nov 23, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@Trott @addaleax
test: fix flaky test-inspector
2fb8257 
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

PR-URL: #9727
Fixes: #8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@Trott @addaleax
test: fix flaky test-inspector
1296a68 
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

PR-URL: nodejs#9727
Fixes: nodejs#8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Trott @MylesBorins
test: fix flaky test-inspector
a2b2c86 
Using `socket.destroy()` instead of `socket.end()` fixes
more-than-intermittent ECONNRESET issues on Windows.

PR-URL: #9727
Fixes: #8804
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
@Trott Trott deleted the fix-test-inspector branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky inspector/test-inspector on Windows
5 participants
@Trott @eugeneo @gibfahn @addaleax @nodejs-github-bot