Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crypto "Verify" typo #9796

Closed
wants to merge 2 commits into from
Closed

fix crypto "Verify" typo #9796

wants to merge 2 commits into from

Conversation

Amery2010
Copy link
Contributor

@Amery2010 Amery2010 commented Nov 25, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

fix crypto "Verify" typo
I am currently translating doc into Chinese, but I found this problem in the translation process.

@Amery2010
fix crypto "Verify" typo
bd6615d 
fix crypto "Verify" typo
I am currently translating doc into Chinese, but I found this problem in the translation process.
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Nov 25, 2016
addaleax
addaleax approved these changes Nov 25, 2016
View reviewed changes
doc/api/crypto.md
@@ -935,8 +935,8 @@ of two ways:
- Using the [`verify.update()`][] and [`verify.verify()`][] methods to verify
the signature.

The [`crypto.createSign()`][] method is used to create `Sign` instances.
`Sign` objects are not to be created directly using the `new` keyword.
The [`crypto.createVerify()`][] method is used to create `Verify` instances. `Verify`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to wrap lines at 80 columns? Thank you :)

@Amery2010
wrap lines at 80 columns
cac3579 
I'm sorry, I did not realize this before.
evanlucas
evanlucas approved these changes Nov 25, 2016
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sam-github
Copy link
Contributor

LGTM

mhdawson
mhdawson approved these changes Nov 25, 2016
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should start with
"doc: "

ie:

doc: fix crypto "Verify" typo

Otherwise LGTM once thats fixedup.

@sam-github
Copy link
Contributor

I can squash and rewrite the commit message when I land this, or @Amery2010 can do it, but I'm supposed to wait two working days, which means not merging until Monday :-(.

Maybe there is a dispensation for such trivially correct improvements, such as this one?

@lpinca
Copy link
Member

lpinca commented Nov 25, 2016

@sam-github I saw some trivial changes like typos being landed without waiting the 48/72 hours.

@sam-github
Copy link
Contributor

Landed in 630c63e

@sam-github sam-github closed this Nov 25, 2016
sam-github pushed a commit that referenced this pull request Nov 25, 2016
@Amery2010 @sam-github
doc: fix crypto Verify cut-n-paste from Sign
630c63e 
Verify documentation had cut-n-pasted documentation from Sign.

PR-URL: #9796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
@sam-github
Copy link
Contributor

@Amery2010 I rewrote your commit message. Please take a look, I'm sure you will need to PR more improvements to docs if you are translating, because you will see many errors.

@mhdawson
Copy link
Member

Agreed that fixing in commit message is ok, but important @Amery2010 is aware for the next time.

addaleax pushed a commit that referenced this pull request Dec 5, 2016
@Amery2010 @addaleax
doc: fix crypto Verify cut-n-paste from Sign
4fa84c9 
Verify documentation had cut-n-pasted documentation from Sign.

PR-URL: #9796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@Amery2010 @MylesBorins
doc: fix crypto Verify cut-n-paste from Sign
9e68b8d 
Verify documentation had cut-n-pasted documentation from Sign.

PR-URL: #9796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@Amery2010 @MylesBorins
doc: fix crypto Verify cut-n-paste from Sign
5396408 
Verify documentation had cut-n-pasted documentation from Sign.

PR-URL: #9796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Amery2010 @MylesBorins
doc: fix crypto Verify cut-n-paste from Sign
27fa071 
Verify documentation had cut-n-pasted documentation from Sign.

PR-URL: #9796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Amery2010 @MylesBorins
doc: fix crypto Verify cut-n-paste from Sign
4ad979d 
Verify documentation had cut-n-pasted documentation from Sign.

PR-URL: #9796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@cjihrig cjihrig cjihrig approved these changes

@princejwesley princejwesley princejwesley approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@evanlucas evanlucas evanlucas approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Amery2010 @sam-github @lpinca @mhdawson @evanlucas @addaleax @princejwesley @cjihrig @MylesBorins @nodejs-github-bot