Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor and fix test-buffer-bytelength #9808

Closed
wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Nov 26, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, buffer

Description of change
  • assert.equal -> assert.strictEqual.
  • Fix incorrect use of string instead of RegExp in throws assertions.

* assert.equal -> assert.strictEqual.
* Fix incorrect use of string instead of RegExp in `throws` assertions.
@targos targos added buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests. labels Nov 26, 2016
@targos
Copy link
Member Author

targos commented Nov 27, 2016

@targos
Copy link
Member Author

targos commented Nov 28, 2016

Landed in 5945044

@targos targos closed this Nov 28, 2016
@targos targos deleted the refactor-test-buffer-bytelength branch November 28, 2016 12:50
targos added a commit that referenced this pull request Nov 28, 2016
* assert.equal -> assert.strictEqual.
* Fix incorrect use of string instead of RegExp in `throws` assertions.

PR-URL: #9808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
* assert.equal -> assert.strictEqual.
* Fix incorrect use of string instead of RegExp in `throws` assertions.

PR-URL: #9808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
@MylesBorins
Copy link
Contributor

@targos these tests do not backport cleanly. Would you want to manually backport?

@targos
Copy link
Member Author

targos commented Dec 26, 2016

The patch is not applicable to v4. Only the strictEqual change is for v6 and I cherry-picked it in 3d368d0

targos added a commit that referenced this pull request Dec 26, 2016
* assert.equal -> assert.strictEqual.

PR-URL: #9808
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins
Copy link
Contributor

thanks for backporting so much stuff @targos!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
buffer Issues and PRs related to the buffer subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants