Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests]Changed var -> const, assert.equal -> assert.strictEqual #9884

Closed
wants to merge 1 commit into from

Conversation

troy0820
Copy link
Contributor

@troy0820 troy0820 commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

Tests

Description of change
  • Changed var to const
  • Changed assert.equal to assert.strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@princejwesley
Copy link
Contributor

princejwesley commented Dec 1, 2016

@troy0820 please change the commit msg as test: change var to const, assert.equal to assert.strictEqual in net!

@troy0820
Copy link
Contributor Author

troy0820 commented Dec 1, 2016

Changed commit message @princejwesley 💥 👍

Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for participating in Code and Learn! Welcome to Node.js!

@Trott
Copy link
Member

Trott commented Dec 3, 2016

@troy0820 I'm really sorry about this but it looks like I messed up and gave a small number of people duplicate tasks at the Code & Learn. Unfortunately, this was one of them. Would it be OK with you if we closed this one and I privately sent you another similar task? This is totally my fault and I apologize.

@troy0820
Copy link
Contributor Author

troy0820 commented Dec 3, 2016

@Trott That's perfectly alright. Whatever you need me to do just send my way and I'll do that. 👍🏽

@cjihrig
Copy link
Contributor

cjihrig commented Dec 4, 2016

Closing. Sorry about the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants