Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove var and use let and const #9903

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/parallel/test-child-process-kill.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
'use strict';
var common = require('../common');
var assert = require('assert');
var spawn = require('child_process').spawn;
var cat = spawn(common.isWindows ? 'cmd' : 'cat');
const common = require('../common');
const assert = require('assert');
const spawn = require('child_process').spawn;
const cat = spawn(common.isWindows ? 'cmd' : 'cat');

cat.stdout.on('end', common.mustCall(function() {}));
cat.stderr.on('data', common.fail);
Expand All @@ -13,6 +13,6 @@ cat.on('exit', common.mustCall(function(code, signal) {
assert.strictEqual(signal, 'SIGTERM');
}));

assert.equal(cat.killed, false);
assert.strictEqual(cat.killed, false);
cat.kill();
assert.equal(cat.killed, true);
assert.strictEqual(cat.killed, true);
20 changes: 10 additions & 10 deletions test/parallel/test-net-reconnect-error.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
'use strict';
var common = require('../common');
var net = require('net');
var assert = require('assert');
var N = 20;
var client_error_count = 0;
var disconnect_count = 0;
const common = require('../common');
const net = require('net');
const assert = require('assert');
const N = 20;
let client_error_count = 0;
let disconnect_count = 0;

// Hopefully nothing is running on common.PORT
var c = net.createConnection(common.PORT);
const c = net.createConnection(common.PORT);

c.on('connect', function() {
console.error('CLIENT connected');
Expand All @@ -17,7 +17,7 @@ c.on('connect', function() {
c.on('error', function(e) {
console.error('CLIENT error: ' + e.code);
client_error_count++;
assert.equal('ECONNREFUSED', e.code);
assert.strictEqual('ECONNREFUSED', e.code);
});

c.on('close', function() {
Expand All @@ -27,6 +27,6 @@ c.on('close', function() {
});

process.on('exit', function() {
assert.equal(N + 1, disconnect_count);
assert.equal(N + 1, client_error_count);
assert.strictEqual(N + 1, disconnect_count);
assert.strictEqual(N + 1, client_error_count);
});
9 changes: 9 additions & 0 deletions test/parallel/test-require-invalid-package.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
'use strict';

require('../common');
const assert = require('assert');

// Should be an invalid package path.
assert.throws(() => require('package.json'), (err) => {
return err && err.code === 'MODULE_NOT_FOUND';
});