Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace assert.equal to assert.strictEqual, var to const/let #9947

Closed
wants to merge 1 commit into from
Closed

test: replace assert.equal to assert.strictEqual, var to const/let #9947

wants to merge 1 commit into from

Conversation

mbchoa
Copy link
Contributor

@mbchoa mbchoa commented Dec 1, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change
  • Replaced var keywords to const / let
  • Replaced assert.equal assertions to use assert.strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@imyller imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. labels Dec 1, 2016
cjihrig
cjihrig approved these changes Dec 4, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

jasnell
jasnell approved these changes Dec 5, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Trott
Copy link
Member

Trott commented Dec 7, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5280/

@italoacasas
Copy link
Contributor

Landed in: da077ee

Thanks for the contribution.

@italoacasas italoacasas closed this Dec 7, 2016
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@mbchoa @addaleax
test: refactor test-dgram-bind-default-address
19432f0 
- changes var to const/let
- changes assert.equal to assert.strictEqual

PR-URL: #9947
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@mbchoa @addaleax
test: refactor test-dgram-bind-default-address
c2d7e67 
- changes var to const/let
- changes assert.equal to assert.strictEqual

PR-URL: nodejs#9947
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@mbchoa @MylesBorins
test: refactor test-dgram-bind-default-address
ee038c0 
- changes var to const/let
- changes assert.equal to assert.strictEqual

PR-URL: #9947
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@mbchoa @MylesBorins
test: refactor test-dgram-bind-default-address
b498700 
- changes var to const/let
- changes assert.equal to assert.strictEqual

PR-URL: #9947
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@mbchoa @MylesBorins
test: refactor test-dgram-bind-default-address
61dc250 
- changes var to const/let
- changes assert.equal to assert.strictEqual

PR-URL: #9947
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mbchoa @Trott @italoacasas @jasnell @addaleax @cjihrig @MylesBorins @imyller @nodejs-github-bot