Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated test-crypto-ecb.js to change assert.equal to assert.strictEqual #9980

Closed
wants to merge 1 commit into from
Closed

Updated test-crypto-ecb.js to change assert.equal to assert.strictEqual #9980

wants to merge 1 commit into from

Conversation

daniel-pittman
Copy link
Contributor

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tests

Description of change

Updated test-crypto-ecb.js to change assert.equal to assert.strictEqual

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Dec 1, 2016
@mscdex
Copy link
Contributor

mscdex commented Dec 1, 2016

Please see the commit message guidelines here.

@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@daniel-pittman
test: Change assert.equal to assert.strictEqual
76fe77f 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual
@daniel-pittman
Copy link
Contributor Author

Git commit message updated.

Trott
Trott approved these changes Dec 4, 2016
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM if CI is ✅

@Trott
Copy link
Member

Trott commented Dec 4, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5163/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 4, 2016
@daniel-pittman @Trott
test: use assert.strictEqual in test-crypto-ecb
99a3b63 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.

PR-URL: nodejs#9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 4, 2016

Landed in 99a3b63. Thanks for the contribution! 🎉

@Trott Trott closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@daniel-pittman @addaleax
test: use assert.strictEqual in test-crypto-ecb
55b58ba 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.

PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@daniel-pittman @addaleax
test: use assert.strictEqual in test-crypto-ecb
f093760 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.

PR-URL: nodejs#9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@daniel-pittman
test: use assert.strictEqual in test-crypto-ecb
6d63eec 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.

PR-URL: nodejs#9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@daniel-pittman @MylesBorins
test: use assert.strictEqual in test-crypto-ecb
76645e8 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.

PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@daniel-pittman @MylesBorins
test: use assert.strictEqual in test-crypto-ecb
31494ab 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.

PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@daniel-pittman @MylesBorins
test: use assert.strictEqual in test-crypto-ecb
c883f41 
Updated test-crypto-ecb.js to change assert.equal
to assert.strictEqual.

PR-URL: #9980
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@daniel-pittman @mscdex @Trott @MylesBorins @addaleax @imyller @nodejs-github-bot