Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Added more validations to setEncoding #9997

Closed
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions test/parallel/test-tls-set-encoding.js
Original file line number Diff line number Diff line change
@@ -1,38 +1,41 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

if (!common.hasCrypto) {
common.skip('missing crypto');
return;
}
var tls = require('tls');
const tls = require('tls');

var fs = require('fs');
const fs = require('fs');


var options = {
const options = {
key: fs.readFileSync(common.fixturesDir + '/keys/agent2-key.pem'),
cert: fs.readFileSync(common.fixturesDir + '/keys/agent2-cert.pem')
};

var message = 'hello world\n';
// Contains a UTF8 only character
const messageUtf8 = 'x√ab c';

// The same string above represented with ASCII
const messageAscii = 'xb\b\u001aab c';

var server = tls.Server(options, common.mustCall(function(socket) {
socket.end(message);
const server = tls.Server(options, common.mustCall(function(socket) {
socket.end(messageUtf8);
}));


server.listen(0, function() {
var client = tls.connect({
const client = tls.connect({
port: this.address().port,
rejectUnauthorized: false
});

var buffer = '';
let buffer = '';

client.setEncoding('utf8');
client.setEncoding('ascii');

client.on('data', function(d) {
assert.ok(typeof d === 'string');
Expand All @@ -44,10 +47,16 @@ server.listen(0, function() {
// readyState is deprecated but we want to make
// sure this isn't triggering an assert in lib/net.js
// See issue #1069.
assert.equal('closed', client.readyState);
assert.strictEqual('closed', client.readyState);

// Confirming the buffer string is encoded in ASCII
// and thus does NOT match the UTF8 string
assert.notEqual(buffer, messageUtf8);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use assert.notStrictEqual() here.


// Confirming the buffer string is encoded in ASCII
// and thus does equal the ASCII string representation
assert.strictEqual(buffer, messageAscii);

assert.equal(buffer, message);
console.log(message);
server.close();
});
});