-
Notifications
You must be signed in to change notification settings - Fork 1k
i18n(folders): added files to respective language folders #3150
Conversation
Codecov ReportBase: 66.02% // Head: 66.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #3150 +/- ##
==========================================
+ Coverage 66.02% 66.39% +0.36%
==========================================
Files 118 145 +27
Lines 1351 1702 +351
Branches 342 393 +51
==========================================
+ Hits 892 1130 +238
- Misses 422 528 +106
- Partials 37 44 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I oppose this change. Because having the contents in the same directory allows a good maintenance. That is to say, if you update you can easily access the translated file.
And this does not respect the Gatsby file structure.
It does. This change does not impact the current URLs/folder structure and how files are indexed/processed. It could, of course, introduce issues with some of our custom route creation based on some file-name/file-path regexes that we have, so I'm not sure. I'm okay with this change, but I highly doubt this will land, as we're freezing this repository for now to avoid non-necessary changes as we're going to migrate stuff from here to |
Currently, I don't see any issues with the file structure. However, over time, I believe support for 7 or more languages becomes an issue - although it may stop at 7 languages. Regarding Gatsby's file structure, the problem I saw was in |
Don't worry, it's really a change that doesn't affect anything major. And since you're going to migrate, I don't see a problem with closing the PR. |
I'm closing the PR. |
Description
Adding folders to better organize translation content
Related Issues
There are no open issues, however a problem that could grow as more developers add support for other languages, it becomes a huge mess of
.md
files. I believe the solution would be to add folders of acronyms for each language to identify them.Check List
npm run lint:js -- --fix
and/ornpm run lint:md -- --fix
for my JavaScript and/or Markdown changes.npm run test
to check if all tests are passing, and/ornpm run test -- -u
to update snapshots if I created and/or updated React Components.npm run build
work fine.