-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding collaborators #181
Comments
Looking at
|
In core we consider people with only a single commit as well. If it's more than a trivial change we onboard them as a committer. |
Also, this might be a little more useful since it's got people's GitHub usernames https://github.com/nodejs/new.nodejs.org/graphs/contributors |
Ok, I'm not sure if we need any "onboarding" here, the website is pretty easy to contribute to and the guidelines are written up. Any objection to adding:
|
Happy to join 👍 |
I'm quite happy if I can help 👍 |
Would be my pleasure to contribute again. |
I would love that :) |
Happy to join 😄 Thanks |
👍 |
4 similar comments
+1 |
👍 |
👍 |
👍 |
Thanks |
[image: 👍] On 8 October 2015 at 09:28, Patrick Heneise notifications@github.com
|
I'm happy to help. |
👍 |
I'd love to help. |
Thanks! I'm open to joining :] |
@fhemberger waiting to get a nod from you before I add everyone :) |
Thanks for readding me! +1 |
@mikeal I still feel a bit uncertain giving so many people commit rights to master (not because of any of the contributors, I simply don't have any experience with this kind of setup). Is it possible to set up some kind of GitHub workflow? (e.g. changes need to be introduced as PR and need another person to merge them.) With the next step of adding all translators to the website repo as well, we would have more than 50 people. What do you think? |
@fhemberger ah, I had assumed that we brought over the contribution policy from core but it looks like we are missing it :) The policy for core is that nobody can merge their own commit, everything is a PR :) I'll send a PR to our README for that. |
@fhemberger Ah, I agree. Too many cooks spoil the broth :D I contribute (though I check most of the PRs) only time to time. So, I would like to opt-out. |
@mikeal Great, thanks. |
Ok, #224 this is based on the governance proposal I put up yesterday. Rather than a "TC" model we have an "admin group" which is elected by the full WG. The obvious candidates at this time would be the top 4 or 5 contributors, but we'll need to do that election shortly after we add all these members :) |
Thanks! I'm definitely open to helping more. |
Great @mikeal! Very happy to get more people on board :) |
We should create a list of proposed people to add as collaborators and potentially even a few to add as Working Group members. I'd like to see this project move to more of an "OPEN Open Source" contribution model and we've had a ton of people show up recently and do great work.
We may also want to schedule a WG meeting soon.
The text was updated successfully, but these errors were encountered: