Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: How to publish N-API package #1236

Merged
merged 4 commits into from
May 25, 2017
Merged

Conversation

aruneshchandra
Copy link
Contributor

This guide provides a recommendation on how to publish an experimental N-API package for easy discovery.

running `npm install iotivity-node`. This will install the non-N-API version
by default. The user will have to run `npm install iotivity-node@n-api` to
receive the N-API version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: what do you think about adding a link to https://docs.npmjs.com/getting-started/using-tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! Thanx

will not be installed if someone chooses to install `iotivity-node` by simply
running `npm install iotivity-node`. This will install the non-N-API version
by default. The user will have to run `npm install iotivity-node@n-api` to
receive the N-API version. For more information on usig tags with npm check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor typo: "usig".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops :(
Thanx - fixed it.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@refack refack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some lite suggestions

- Then, publish the N-API version:
- Update the version in `package.json`. For `iotivity-node`, the version
becomes `1.2.0-3`. For version number, the field after the dash (-) allows
quite a bit of flexibility to insert any text. e.g. `1.2.0-napi`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[lite suggestion]Maybe link to http://semver.org/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

running `npm install iotivity-node`. This will install the non-N-API version
by default. The user will have to run `npm install iotivity-node@n-api` to
receive the N-API version. For more information on using tags with npm check
out https://docs.npmjs.com/getting-started/using-tags
Copy link
Contributor

@refack refack May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Suggestion] I would call the link by it's name:
check out ["Using dist-tags"](https://docs.npmjs.com/getting-started/using-tags).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
```

Note that, unlike regular versions, tagged versions cannot be addressed by
Copy link
Contributor

@refack refack May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion]

Copy link
Member

@gibfahn gibfahn May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if you're referring to it twice, you might as well use the

["Using dist-tags"][]


["Using dist-tags"]: https://docs.npmjs.com/getting-started/using-tags

format

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@aruneshchandra
Copy link
Contributor Author

Thanx for all the reviews! Can someone please land this for me ?

@gibfahn gibfahn merged commit 46ae677 into nodejs:master May 25, 2017
@gibfahn
Copy link
Member

gibfahn commented May 25, 2017

@fhemberger let me know if I did anything wrong.

@fhemberger
Copy link
Contributor

@gibfahn No worries, LGTM!

@aruneshchandra
Copy link
Contributor Author

@fhemberger - do we know when this change will show up on the website ? I have a N-API announcement blog coming up next week and would like to point to this content with an official URL.

@lpinca
Copy link
Member

lpinca commented May 26, 2017

@aruneshchandra it is visible: https://nodejs.org/en/docs/guides/publishing-napi-modules/. Site is deployed on every push on master.

@aruneshchandra
Copy link
Contributor Author

Ah thanx! I see it now - for some reason I did not see it earlier :/

@fhemberger
Copy link
Contributor

@aruneshchandra Site is cached by Cloudflare, it can sometimes take up to an hour for the changes to be visible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants